Skip to content

Import v2 network metadata#2466

Merged
MrAlias merged 1 commit into
open-telemetry:mainfrom
MrAlias:codex/config-v2-import-network
Jun 26, 2026
Merged

Import v2 network metadata#2466
MrAlias merged 1 commit into
open-telemetry:mainfrom
MrAlias:codex/config-v2-import-network

Conversation

@MrAlias

@MrAlias MrAlias commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Depends on #2462

Summary

  • Import network capture CIDR definitions, compatible signal filters, and GeoIP/reverse DNS enrichment from the v2 config shape.
  • Tighten network capture/stats completeness checks so partial v2 sections preserve runtime defaults for omitted metadata fields.
  • Add focused network import parity coverage for capture metadata, stats metadata, and unsupported divergent filter shapes.

Validation

  • make generate
  • go test ./internal/config/...
  • go test ./cmd/check-config-v2-parity
  • make check-config-v2-parity

@codecov

codecov Bot commented Jun 22, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 53.06122% with 23 lines in your changes missing coverage. Please review.
✅ Project coverage is 68.86%. Comparing base (914ffa4) to head (91ade68).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/config/convert/import.go 53.06% 20 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2466      +/-   ##
==========================================
- Coverage   69.24%   68.86%   -0.39%     
==========================================
  Files         345      345              
  Lines       46747    46795      +48     
==========================================
- Hits        32372    32224     -148     
- Misses      12330    12537     +207     
+ Partials     2045     2034      -11     
Flag Coverage Δ
integration-test 50.85% <ø> (-0.07%) ⬇️
integration-test-arm 26.27% <ø> (-2.03%) ⬇️
integration-test-vm-5.15-lts ?
integration-test-vm-6.18-lts ?
k8s-integration-test 35.93% <ø> (+0.23%) ⬆️
oats-test 35.68% <ø> (+0.32%) ⬆️
unittests 63.37% <53.06%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@MrAlias MrAlias force-pushed the codex/config-v2-import-network branch from 4e18cf2 to facff22 Compare June 25, 2026 15:51
@MrAlias MrAlias marked this pull request as ready for review June 25, 2026 17:35
@MrAlias MrAlias requested a review from a team as a code owner June 25, 2026 17:35

@grcevski grcevski left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mariomac mariomac left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Restore v2 import parity for network capture metadata that RuntimeToV2 already exports. Capture CIDR definitions, compatible signal filters, and GeoIP and reverse DNS enrichment now round-trip into the runtime network configuration.

Tighten network capture and stats completeness checks so omitted v2 subsections keep runtime defaults instead of clearing fields that were not present in a partial import.
@MrAlias MrAlias force-pushed the codex/config-v2-import-network branch from facff22 to 91ade68 Compare June 26, 2026 14:47
@MrAlias MrAlias merged commit ed913ad into open-telemetry:main Jun 26, 2026
98 checks passed
@MrAlias MrAlias deleted the codex/config-v2-import-network branch June 26, 2026 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants