Import v2 enrichment config#2468
Merged
MrAlias merged 3 commits intoJun 26, 2026
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2468 +/- ##
==========================================
- Coverage 69.24% 69.10% -0.15%
==========================================
Files 345 347 +2
Lines 46747 46879 +132
==========================================
+ Hits 32372 32396 +24
- Misses 12330 12421 +91
- Partials 2045 2062 +17
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
MrAlias
force-pushed
the
codex/config-v2-import-enrich
branch
2 times, most recently
from
7fe7fdc to
c51b093
Compare
grcevski
reviewed
Jun 25, 2026
Apply standalone v2 enrich attributes and Kubernetes enricher settings back into the runtime config so exported documents preserve enrichment behavior when imported. The importer now clones attribute selections, extra group attributes, and Kubernetes label maps to keep the schema object isolated from runtime state while preserving defaults for missing sections.
Map Kubernetes enricher mode through the v2 enum so exported configs emit enabled and disabled while runtime config still receives true and false. Preserve exported zero values for metadata retry timeout and Kubernetes informer resync period during v2 import. The tests now cover those round trips while keeping empty enrich sections on the runtime defaults.
Include the package import comment on the new enrich converter helper so porto accepts it during the lint workflow. The previous commit added the file without the vanity import marker, which caused the PR lint job to fail before the rest of lint could run cleanly.
MrAlias
force-pushed
the
codex/config-v2-import-enrich
branch
from
0a86ed7 to
43e460a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #2462
Summary
enrich.attributesinto runtime attribute settings.enrich.enrichers.kubernetesfields exported byRuntimeToV2.Validation
make generatego test ./internal/config/...go test ./cmd/check-config-v2-paritymake check-config-v2-parity