Fix chunked response size overflow#2520
Merged
grcevski merged 1 commit intoJun 26, 2026
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2520 +/- ##
==========================================
- Coverage 69.24% 69.07% -0.18%
==========================================
Files 345 345
Lines 46747 46796 +49
==========================================
- Hits 32372 32326 -46
- Misses 12330 12435 +105
+ Partials 2045 2035 -10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
rafaelroquetto
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
int64and added it to a slice index without checking for overflow, allowing an attacker-controlled large chunk size to cause a runtime panic and crash the agent.Description
strconv.ParseUintand remove the signed-negative check to avoid incorrect casting.available := len(data) - chunkStartand treat anychunkSizegreater thanavailableas a truncated chunk before converting tointand slicing.TestDechunkBodythat asserts an oversized advertised chunk ("7fffffffffffffff\r\nA") is treated as truncated and returns the available bytes.Testing
go test ./pkg/ebpf/common -run 'TestDechunkBody|TestHttpSafeParseResponseChunked'