Fix gRPC server conn user memory reads#2522
Open
MrAlias wants to merge 1 commit into
Open
Conversation
Keep gRPC server connection pointer traversal on the user-memory read path after the transport pointer is read from Go memory. This avoids generic pointer chasing with kernel read helpers for values sourced from instrumented Go memory. Label the debug output so the user-memory path can be distinguished from the generic helper when BPF debug logging is enabled.
MrAlias
added
bug
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2522 +/- ##
==========================================
+ Coverage 69.03% 69.15% +0.12%
==========================================
Files 348 348
Lines 47314 47314
==========================================
+ Hits 32663 32721 +58
+ Misses 12598 12530 -68
- Partials 2053 2063 +10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
bpf_probe_readdereferences of pointer values sourced from instrumented Go user memory for gRPC server transports.net.Conn/netFD/address details for telemetry while ensuring all pointer chasing of user-origin memory uses user helpers.Description
read_user_ip_and_port,get_conn_info_from_user_fd,fd_ptr_from_user_conn, andget_conn_info_from_user_conntobpf/gotracer/go_common.hto traverse Go connection pointer chains usingbpf_probe_read_userfor all user-originated dereferences.grpc_server_conn_infoinbpf/gotracer/go_grpc.cto callget_conn_info_from_user_connafter readinghttp2Server.connwithbpf_probe_read_userso the entire chain remains on the user-memory read path.Testing
go test ./pkg/ebpf/commonclang -target bpf -D__TARGET_ARCH_x86 -O2 -g -I bpf -c bpf/gotracer/gotracer.c -o .tmp/gotracer.o