Export selector route refinements#2523
Open
MrAlias wants to merge 1 commit into
Open
Conversation
Selector route overrides were importable in config v2, but RuntimeToV2 still skipped them because the export path only emitted export-mode refinements. This left a stale TODO and made round-trip coverage depend on manually authored v2 input. Emit incoming and outgoing selector route patterns in the rule HTTP refinement shape so exported configs preserve per-selector route overrides. Update the advanced capture parity test to assert the direction-aware fields.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2523 +/- ##
==========================================
+ Coverage 69.07% 69.17% +0.09%
==========================================
Files 348 348
Lines 47314 47320 +6
==========================================
+ Hits 32683 32734 +51
+ Misses 12582 12523 -59
- Partials 2049 2063 +14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
capture.rules[].refine.http.routes.Validation
go test ./internal/config/convertgo test ./internal/config/...make check-config-v2-parity