Weaver: document undocumented produced attributes + violate on extends_namespace#2526
Open
NimrodAvni78 wants to merge 3 commits into
Open
Weaver: document undocumented produced attributes + violate on extends_namespace#2526NimrodAvni78 wants to merge 3 commits into
NimrodAvni78 wants to merge 3 commits into
Conversation
weaver updates weaver updates fix tests fixes fixes
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2526 +/- ##
==========================================
- Coverage 69.24% 69.11% -0.14%
==========================================
Files 345 348 +3
Lines 46747 47380 +633
==========================================
+ Hits 32372 32748 +376
- Misses 12330 12573 +243
- Partials 2045 2059 +14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
MrAlias
requested changes
Jun 29, 2026
MrAlias
left a comment
MrAlias
left a comment
Contributor
There was a problem hiding this comment.
Thanks for tightening the weaver validation path and adding the missing OBI registry attributes. I found one issue in the new enforcement logic that keeps the extends_namespace advisory from becoming actionable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OBI produces a few attributes which are not part of the semconv. weaver does not take it as a violation since its under a known namespace. this both fixes this and adds
extends_namespaceadvisories to produce weaver errors. and adds the undocumented attributes to OBIs schema registryValidation