opentelemetry_oban: Update semantic conventiosn version from ~> 0.2 to ~> 1.0 #570
+17
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hi @jadengis, For what is worth, there's feedback in a few other PRs that also try to update the same thing. See #428 (comment). Maybe you get a sense whether this could or not be accepted based on feedback in those other previous pull requests. (I am not an approver nor maintainer) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I removed the
Trace.messaging_destination_kind()calls because there is no equivalent tag attribute in the current version ofopentelemetry_semantic_conventions.Tests were updated to match the new expectations. Let me know if there are any changes that you'd like to see happen.