feat(opentelemetry_phoenix): add controller render tracing #584
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for tracing Phoenix controller render events. This enables instrumentation of template rendering within controller actions, providing visibility into view rendering performance. Changes: - Attach telemetry handlers for controller render start/stop/exception - Implement span creation for controller renders with format: ViewModule#template.format (e.g., MyAppWeb.PageView#index.html) - Add test coverage for controller render tracing - Update module documentation to mention controller render events The implementation follows the same pattern as the LiveView handlers.
Add optional configuration to enable/disable controller render tracing. The feature is enabled by default and can be disabled by passing `controller: false` to `setup/1`. Changes: - Add `controller` boolean option to setup (defaults to true) - Conditionally attach controller render handlers based on option - Add test coverage for disabled controller render tracing
|
Member
|
@jeffkreeftmeijer thanks! I'd like to hear from others why these weren't already instrumented as I am not very familiar with Phoenix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're exploring adopting OpenTelemetry for our Elixir offering at AppSignal and found that controller render actions weren't being traced.
This PR adds support for tracing Phoenix controller render events, enabling instrumentation of template rendering within controller actions.
Changes
ViewModule#template.format(e.g.,MyAppWeb.PageView#index.html)controllerconfiguration option (enabled by default, can be disabled withcontroller: false). Added in a separate commit in case we'd like to keep this out.