-
Notifications
You must be signed in to change notification settings - Fork 652
feat: adding instrumentation support for mongo-driver/v2 #6539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6539 +/- ##
======================================
Coverage 81.1% 81.2%
======================================
Files 204 207 +3
Lines 18140 18263 +123
======================================
+ Hits 14723 14832 +109
- Misses 2999 3009 +10
- Partials 418 422 +4
🚀 New features to boost your workflow:
|
cc @prestonvasquez for review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AlaricWhitney Thank you for putting this together. I wanted to let you know that I'll be reviewing this in stages, as my schedule allows.
instrumentation/go.mongodb.org/mongo-driver/v2/mongo/otelmongo/doc.go
Outdated
Show resolved
Hide resolved
instrumentation/go.mongodb.org/mongo-driver/v2/mongo/otelmongo/doc.go
Outdated
Show resolved
Hide resolved
instrumentation/go.mongodb.org/mongo-driver/v2/mongo/otelmongo/doc.go
Outdated
Show resolved
Hide resolved
instrumentation/go.mongodb.org/mongo-driver/v2/mongo/otelmongo/version.go
Outdated
Show resolved
Hide resolved
instrumentation/go.mongodb.org/mongo-driver/v2/mongo/otelmongo/version.go
Show resolved
Hide resolved
instrumentation/go.mongodb.org/mongo-driver/v2/mongo/otelmongo/test/version_test.go
Outdated
Show resolved
Hide resolved
instrumentation/go.mongodb.org/mongo-driver/v2/mongo/otelmongo/test/doc.go
Outdated
Show resolved
Hide resolved
instrumentation/go.mongodb.org/mongo-driver/v2/mongo/otelmongo/version.go
Outdated
Show resolved
Hide resolved
instrumentation/go.mongodb.org/mongo-driver/v2/mongo/otelmongo/test/version.go
Outdated
Show resolved
Hide resolved
can this pr merge? I need use it in my project |
Not until all review comments have been closed an it has been approved. |
…/doc.go Co-authored-by: Preston Vasquez <[email protected]>
…/doc.go Co-authored-by: Preston Vasquez <[email protected]>
…/test/doc.go Co-authored-by: Preston Vasquez <[email protected]>
…/test/version.go Co-authored-by: Damien Mathieu <[email protected]>
…/version.go Co-authored-by: Preston Vasquez <[email protected]>
…tation for go.mongodb.org/mongo-driver/v2
Co-authored-by: Damien Mathieu <[email protected]>
thank's @AlaricWhitney for your work |
@dmathieu is there anything else to do to get this merged? |
cc @open-telemetry/go-approvers for second review. |
Co-authored-by: Damien Mathieu <[email protected]>
instrumentation/go.mongodb.org/mongo-driver/v2/mongo/otelmongo/mongo.go
Outdated
Show resolved
Hide resolved
…/mongo.go Co-authored-by: Sam Xie <[email protected]>
instrumentation/go.mongodb.org/mongo-driver/v2/mongo/otelmongo/mongo.go
Outdated
Show resolved
Hide resolved
…/mongo.go Co-authored-by: Sam Xie <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Adding the mongo-driver/v2 instrumentation.
This is a copy/paste of the v1 instrumentation, and was modified to adhere to the mongo-driver/v2 requirements.
Notable differences:
mtest
was removed in v2. Replaced withdrivertest
in the unit testing.This addresses PR #6419