Skip to content

otelhttp: Ignore informational response status codes when persisting status #6913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

VirrageS
Copy link

Closes #6912

@VirrageS VirrageS requested review from dmathieu and a team as code owners March 11, 2025 10:07
@VirrageS VirrageS force-pushed the update-writeheader branch from 607baeb to 2e15df2 Compare March 11, 2025 10:19
Copy link

codecov bot commented Mar 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.6%. Comparing base (3ea6585) to head (5e505fb).
Report is 5 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #6913   +/-   ##
=====================================
  Coverage   75.5%   75.6%           
=====================================
  Files        207     207           
  Lines      19319   19364   +45     
=====================================
+ Hits       14601   14653   +52     
+ Misses      4283    4275    -8     
- Partials     435     436    +1     
Files with missing lines Coverage Δ
...ux/otelmux/internal/request/resp_writer_wrapper.go 100.0% <100.0%> (ø)
...p/otelhttp/internal/request/resp_writer_wrapper.go 100.0% <100.0%> (ø)

... and 6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@VirrageS VirrageS force-pushed the update-writeheader branch from 2e15df2 to 7d2573f Compare March 11, 2025 15:13
@VirrageS
Copy link
Author

@dmathieu Should I add it to Changelog?

@dmathieu
Copy link
Member

Yes, please

@VirrageS VirrageS force-pushed the update-writeheader branch from 7d2573f to 9b84d37 Compare March 12, 2025 10:56
@VirrageS VirrageS changed the title otelhttp: Ignore informational header when persisting status otelhttp: Ignore informational response status codes when persisting status Mar 12, 2025
@VirrageS VirrageS force-pushed the update-writeheader branch from 9b84d37 to 84dde92 Compare March 12, 2025 11:00
@VirrageS VirrageS force-pushed the update-writeheader branch from 84dde92 to 034029c Compare March 12, 2025 11:54
@github-actions github-actions bot requested a review from akats7 March 12, 2025 11:54
@VirrageS VirrageS force-pushed the update-writeheader branch from 034029c to 5e505fb Compare March 12, 2025 11:57
@VirrageS VirrageS force-pushed the update-writeheader branch from 5e505fb to 98e82cc Compare March 13, 2025 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RespWriterWrapper incorrectly handles 100 Continue response
2 participants