-
Notifications
You must be signed in to change notification settings - Fork 651
otelhttp: Ignore informational response status codes when persisting status #6913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
VirrageS
wants to merge
1
commit into
open-telemetry:main
Choose a base branch
from
VirrageS:update-writeheader
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
607baeb
to
2e15df2
Compare
dmathieu
reviewed
Mar 11, 2025
instrumentation/net/http/otelhttp/internal/request/resp_writer_wrapper.go
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6913 +/- ##
=====================================
Coverage 75.5% 75.6%
=====================================
Files 207 207
Lines 19319 19364 +45
=====================================
+ Hits 14601 14653 +52
+ Misses 4283 4275 -8
- Partials 435 436 +1
🚀 New features to boost your workflow:
|
2e15df2
to
7d2573f
Compare
@dmathieu Should I add it to Changelog? |
Yes, please |
7d2573f
to
9b84d37
Compare
9b84d37
to
84dde92
Compare
dmathieu
reviewed
Mar 12, 2025
instrumentation/net/http/otelhttp/internal/request/resp_writer_wrapper.go
Show resolved
Hide resolved
84dde92
to
034029c
Compare
034029c
to
5e505fb
Compare
dmathieu
approved these changes
Mar 12, 2025
…status Signed-off-by: Janusz Marcinkiewicz <[email protected]>
5e505fb
to
98e82cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6912