refactor: move example from otelmux to make it a testable example #7121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Noé Tarbouriech <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7121 +/- ##
=======================================
+ Coverage 75.8% 76.0% +0.1%
=======================================
Files 207 206 -1
Lines 19484 19445 -39
=======================================
+ Hits 14780 14783 +3
+ Misses 4267 4226 -41
+ Partials 437 436 -1 🚀 New features to boost your workflow:
|
noetarbouriech
changed the title
MrAlias
reviewed
Apr 3, 2025
akats7
reviewed
Apr 4, 2025
| @@ -11,11 +11,18 @@ require ( | |||
| go.opentelemetry.io/otel/trace v1.35.0 | |||
| ) | |||
|
|
|||
| require ( | |||
| github.com/google/uuid v1.6.0 // indirect | |||
| go.opentelemetry.io/otel/sdk v1.35.0 // indirect | |||
There was a problem hiding this comment.
@noetarbouriech this go.mod does not seem up to date, can you run go mod tidy
There was a problem hiding this comment.
Oops, sorry my bad. It should be fine now.
dmathieu
reviewed
Apr 8, 2025
| go.opentelemetry.io/otel/trace v1.35.0 | ||
| ) | ||
|
|
||
| require ( |
There was a problem hiding this comment.
Did Go generate this change, or did you manually update the file?
It's a bit weird to have a new section for indirect dependencies, and a direct one within indirects.
You should generate go.mod with go mod tidy, not need to update it manually.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #7064
I simply moved the old example to have it shown on the pkg.go.dev page. It will require testing for metrics in the future.