Remove StreamClientInterceptor
#7126
Open
+3
−787
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MrAlias I have signed the EasyCLA as you instructed me. I assume i have to wait for your validation. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7126 +/- ##
=======================================
- Coverage 80.7% 80.6% -0.1%
=======================================
Files 205 205
Lines 18083 17977 -106
=======================================
- Hits 14601 14505 -96
+ Misses 3062 3057 -5
+ Partials 420 415 -5
🚀 New features to boost your workflow:
|
adambl06
force-pushed
the
fix/issue-7105
branch
3 times, most recently
from
3c39ff0 to
fa6ad66
Compare
MrAlias
approved these changes
Apr 3, 2025
| assert.Equal(t, codes.Error, span.Status().Code) | ||
| } | ||
|
|
||
| // serverChecks can't be removed in #7105. Should be removed when issue #7106 is fixed. |
There was a problem hiding this comment.
Suggested change
| // serverChecks can't be removed in #7105. Should be removed when issue #7106 is fixed. | |
| // TODO: Remove when issue #7106 is fixed. |
There was a problem hiding this comment.
#7106 has been fixed, since it's closed. Should serverChecks be removed?
MrAlias
changed the title
StreamClientInterceptor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I removed the deprecated code related the deprecated function StreamClientInterceptor.
Side note: serverChecks in interceptor_test.go was not deleted on this branch as used in UnaryServerInterceptor that is cleaned in #7106.
Closes #7105