Fix client metrics recording on round trip error

[alimikegami]

This pull request fixes client metrics recording on round trip error

Related issues: #6940

Does this approach correctly address the issue with round trip errors?
Should I add specific tests to verify metric recording (http.client.duration) during round trip errors?

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: alimikegami / name: Alim Ikegami (e604a87, 5fae8b3, 1f27a0c, c0daa42)

[dmathieu]

Duplicating code like isn't really maintainable long-term. We should be able to have the metrics recorded, with no code duplication. Possibly, by exporting the metric into its own method.

Also, this needs to be tested.

[alimikegami]

Thank you for the review @dmathieu

What do you think of my latest commit? I’ve added a method to record metrics and removed most of the unnecessary code duplication. Thank you.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.8%. Comparing base (5e1f920) to head (e604a87).
Report is 70 commits behind head on main.

Additional details and impacted files

@@          Coverage Diff           @@
##            main   #7146    +/-   ##
======================================
  Coverage   75.8%   75.8%            
======================================
  Files        207     206     -1     
  Lines      19484   19258   -226     
======================================
- Hits       14783   14612   -171     
+ Misses      4265    4213    -52     
+ Partials     436     433     -3     

Files with missing lines	Coverage Δ
instrumentation/net/http/otelhttp/transport.go	95.3% <100.0%> (+0.5%)	⬆️

... and 27 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[dmathieu]

Could you add a test?

[dmathieu]

How about calling this before the error check, in a defer statement?

[alimikegami]

Thank you for the review @dmathieu
I've added the test and refactored the metric recording to use defer, removing the remaining code duplication.

Please check my latest commit. Thank you!