-
Notifications
You must be signed in to change notification settings - Fork 651
build: add version check for go mod #7229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7229 +/- ##
=====================================
Coverage 81.0% 81.0%
=====================================
Files 204 204
Lines 18080 18080
=====================================
+ Hits 14651 14654 +3
+ Misses 3003 3001 -2
+ Partials 426 425 -1 🚀 New features to boost your workflow:
|
This is a nice idea. How about a new tool in Then, we can have a new CI task that uses the proper Go version. |
I will study how the internal/tools directory operates. I'll first set this PR to draft mode. |
@dmathieu I'm wondering if it's appropriate for us to use According to most people's understanding, However, the effect we actually want is for all Go Mods to be uniform. For this reason, would If you have a better name, you can also let me know.
|
EXPECTED_GO_VERSION seems like a good idea. |
This seems to be skippable CHANGELOG.
Usage:
MINIMUM_GO_VERSION="go 1.23.0" make verify-goversion