-
Notifications
You must be signed in to change notification settings - Fork 671
otelconf: add tests for grpc exporters with different certificate configurations #7233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
otelconf: add tests for grpc exporters with different certificate configurations #7233
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7233 +/- ##
=======================================
+ Coverage 81.0% 81.1% +0.1%
=======================================
Files 204 204
Lines 18080 18148 +68
=======================================
+ Hits 14651 14729 +78
+ Misses 3003 3000 -3
+ Partials 426 419 -7 🚀 New features to boost your workflow:
|
@pellared this should be ready for review now - I'm not sure if a changelog entry is needed as this PR only adds tests. |
From build failure
Guessing that |
…nto otelconf-grpc-exporter-test # Conflicts: # otelconf/go.mod
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
n, err := net.Listen("tcp", "localhost:0") | ||
require.NoError(t, err) | ||
|
||
// this is a workaround, as providing 127.0.0.1 resulted in an "invalid URI for request" error |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please create an issue for the bug it and reference it here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure, will do that today
Can you fix the CI? |
fixed |
This PR adds component tests for the otlp grpc exporters for logs/metrics/traces. The tests work by starting a simple grpc server that implements the
Export
interface of the respective signals, and records what is being sent to it. This should server as a way to verify that the otlp exporters created within this package are able to communicate with the server.Closes #7222