-
Notifications
You must be signed in to change notification settings - Fork 651
refactor(otelgin): marked as deprecated the old types and functions #7244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
flc1125
wants to merge
10
commits into
open-telemetry:main
Choose a base branch
from
flc1125:otelgin-option
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7244 +/- ##
=====================================
Coverage 81.1% 81.1%
=====================================
Files 204 204
Lines 18140 18140
=====================================
Hits 14720 14720
Misses 3001 3001
Partials 419 419
🚀 New features to boost your workflow:
|
I think this needs to be split into multiple PRs.
|
Agreed. Actually, I'm also hesitating whether to give users some transition time. |
The deprecations give you that. For signature renames, you can't really do it. |
… in preparation for v0.61.0
…ons as deprecated
…ons as deprecated
pellared
reviewed
Apr 28, 2025
…nctions in favor of GinFilter and GinMetricAttributeFn
# Conflicts: # CHANGELOG.md
…ributeFn in otelgin
pellared
reviewed
Apr 29, 2025
pellared
reviewed
Apr 29, 2025
instrumentation/github.com/gin-gonic/gin/otelgin/test/gin_test.go
Outdated
Show resolved
Hide resolved
instrumentation/github.com/gin-gonic/gin/otelgin/test/gin_test.go
Outdated
Show resolved
Hide resolved
instrumentation/github.com/gin-gonic/gin/otelgin/test/gin_test.go
Outdated
Show resolved
Hide resolved
# Conflicts: # CHANGELOG.md
…etricAttributeFn in otelgin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #7228 and change plan.