Skip to content

refactor(otelgin): marked as deprecated the old types and functions #7244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

flc1125
Copy link
Member

@flc1125 flc1125 commented Apr 19, 2025

see #7228 and change plan.

@github-actions github-actions bot requested a review from akats7 April 19, 2025 15:52
Copy link

codecov bot commented Apr 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.1%. Comparing base (50278fa) to head (73da8f4).

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #7244   +/-   ##
=====================================
  Coverage   81.1%   81.1%           
=====================================
  Files        204     204           
  Lines      18140   18140           
=====================================
  Hits       14720   14720           
  Misses      3001    3001           
  Partials     419     419           
Files with missing lines Coverage Δ
...ntation/github.com/gin-gonic/gin/otelgin/config.go 100.0% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@flc1125 flc1125 marked this pull request as ready for review April 19, 2025 15:59
@flc1125 flc1125 requested a review from a team as a code owner April 19, 2025 15:59
@dmathieu
Copy link
Member

I think this needs to be split into multiple PRs.

  • One that deprecates the Gin* methods.
  • One that removes the Gin* methods (after one release).
  • One that has the heavy breaking change of changing the method signatures.

@flc1125
Copy link
Member Author

flc1125 commented Apr 22, 2025

I think this needs to be split into multiple PRs.

  • One that deprecates the Gin* methods.
  • One that removes the Gin* methods (after one release).
  • One that has the heavy breaking change of changing the method signatures.

Agreed. Actually, I'm also hesitating whether to give users some transition time.

@dmathieu
Copy link
Member

The deprecations give you that. For signature renames, you can't really do it.

@flc1125 flc1125 marked this pull request as draft April 22, 2025 09:45
@flc1125 flc1125 marked this pull request as ready for review April 23, 2025 15:24
@flc1125 flc1125 changed the title otelgin: remove redundant Option designs and simplify naming refactor(otelgin): marked as deprecated the old types and functions Apr 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants