Skip to content

feat: Support mixed categories for semconv opt-in #7274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

prestonvasquez
Copy link
Member

Resolves #7246

Introducing support for category-specific values in the OTEL_SEMCONV_STABILITY_OPT_IN environment variable for otelhttp and otelmongo. For example, multiple categories should be supported without error:

export OTEL_SEMCONV_STABILITY_OPT_IN=http,database,messaging/dup

@github-actions github-actions bot requested a review from dmathieu April 27, 2025 04:30
Copy link

codecov bot commented Apr 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.4%. Comparing base (a35d2d8) to head (ae167e0).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #7274   +/-   ##
=====================================
  Coverage   81.4%   81.4%           
=====================================
  Files        206     206           
  Lines      18230   18270   +40     
=====================================
+ Hits       14848   14885   +37     
- Misses      2961    2963    +2     
- Partials     421     422    +1     
Files with missing lines Coverage Δ
...lei/go-restful/otelrestful/internal/semconv/env.go 94.9% <100.0%> (+0.1%) ⬆️
....com/gin-gonic/gin/otelgin/internal/semconv/env.go 94.9% <100.0%> (+0.1%) ⬆️
...ub.com/gorilla/mux/otelmux/internal/semconv/env.go 93.0% <100.0%> (+0.2%) ⬆️
.../mongo/otelmongo/internal/semconv/event_monitor.go 100.0% <100.0%> (ø)
...tp/httptrace/otelhttptrace/internal/semconv/env.go 90.5% <100.0%> (+0.3%) ⬆️
...entation/net/http/otelhttp/internal/semconv/env.go 90.5% <100.0%> (+0.3%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions github-actions bot requested review from akats7, dashpole and flc1125 April 27, 2025 06:19
@prestonvasquez prestonvasquez marked this pull request as ready for review May 7, 2025 17:15
@prestonvasquez prestonvasquez requested a review from a team as a code owner May 7, 2025 17:15
@prestonvasquez prestonvasquez requested a review from dmathieu May 7, 2025 17:16
@dmathieu dmathieu merged commit 158bafc into open-telemetry:main May 19, 2025
27 checks passed
@MrAlias MrAlias added this to the v1.36.0 milestone May 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Instrumentation should assume OTEL_SEMCONV_STABILITY_OPT_IN has a list of values
5 participants