-
Notifications
You must be signed in to change notification settings - Fork 672
feat: Support mixed categories for semconv opt-in #7274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
dmathieu
merged 13 commits into
open-telemetry:main
from
prestonvasquez:support-semconv-optin-mixed-categories
May 19, 2025
Merged
feat: Support mixed categories for semconv opt-in #7274
dmathieu
merged 13 commits into
open-telemetry:main
from
prestonvasquez:support-semconv-optin-mixed-categories
May 19, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7274 +/- ##
=====================================
Coverage 81.4% 81.4%
=====================================
Files 206 206
Lines 18230 18270 +40
=====================================
+ Hits 14848 14885 +37
- Misses 2961 2963 +2
- Partials 421 422 +1
🚀 New features to boost your workflow:
|
dmathieu
reviewed
Apr 28, 2025
instrumentation/github.com/emicklei/go-restful/otelrestful/internal/semconv/env.go
Outdated
Show resolved
Hide resolved
pellared
approved these changes
May 12, 2025
dmathieu
approved these changes
May 12, 2025
pellared
reviewed
May 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #7246
Introducing support for category-specific values in the OTEL_SEMCONV_STABILITY_OPT_IN environment variable for otelhttp and otelmongo. For example, multiple categories should be supported without error: