Add test cases to TestEmit in attribute
#7751
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added test case for Key.Emit() with BoolSliceValue.
itssaharsh
requested review from
MrAlias,
XSAM,
dashpole,
dmathieu,
flc1125 and
pellared
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds test coverage for BoolSliceValue in the Key.Emit() method, which was previously missing from the test suite.
- Adds a new test case for
BoolSliceValuetype in theTestEmitfunction - The test verifies that
BoolSliceValueemits the correct string representation format
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
flc1125
reviewed
Jan 5, 2026
Member
flc1125
left a comment
flc1125
left a comment
There was a problem hiding this comment.
Based on the tests for Emit(), similar ones such as IntValue and IntSliceValue are also missing. Would you be willing to add those as well.
pellared
changed the title
pellared
approved these changes
Jan 5, 2026
Member
pellared
left a comment
pellared
left a comment
There was a problem hiding this comment.
Please fix the lint issue. Otherwise, LGTM
Contributor
Author
Hey, tried that i am new to contributing to otel where should move from this file . I want to add features /fix bugs but I was currently only able to understand the code I edited |
flc1125
approved these changes
Jan 5, 2026
MrAlias
changed the title
TestEmit in attribute
MrAlias
reviewed
Jan 5, 2026
Co-authored-by: Tyler Yahn <[email protected]>
MrAlias
approved these changes
Jan 5, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add test cases for
Key.Emit()values:BoolSliceValueIntValueIntSliceValue