Checked if instrument enabled before measuring in oteltracegrpc
#7825
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itssaharsh
requested review from
MrAlias,
XSAM,
dashpole,
dmathieu,
flc1125 and
pellared
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7825 +/- ##
=======================================
- Coverage 81.7% 81.7% -0.1%
=======================================
Files 304 304
Lines 23252 23260 +8
=======================================
+ Hits 19009 19015 +6
- Misses 3860 3862 +2
Partials 383 383
🚀 New features to boost your workflow:
|
MrAlias
reviewed
Jan 22, 2026
exporters/otlp/otlptrace/otlptracegrpc/internal/observ/instrumentation.go
Outdated
Show resolved
Hide resolved
exporters/otlp/otlptrace/otlptracegrpc/internal/observ/instrumentation.go
Outdated
Show resolved
Hide resolved
Comment on lines
+246
to
+249
| success := successful(e.nSpans, err) | ||
| addOpt := get[metric.AddOption](addOptPool) | ||
| defer put(addOptPool, addOpt) | ||
| *addOpt = append(*addOpt, e.inst.addOpt) |
Contributor
There was a problem hiding this comment.
Preserve the existing code flow. Changing this is not needed and a distraction for this PR.
Contributor
Author
There was a problem hiding this comment.
Hey so I got stuck here because if the if block in which success is there doesn't run the other block where success is used will panick that's why I changed structure.
| } | ||
|
|
||
| recOpt := get[metric.RecordOption](recordOptPool) | ||
| defer put(recordOptPool, recOpt) |
Contributor
Author
There was a problem hiding this comment.
I changed it because I wanted to put back the slice manually each time. I will change it to defer if it is better but I thought putting it back instantly would be better.
16 tasks
MrAlias
changed the title
oteltracegrpc
…entation.go Co-authored-by: Tyler Yahn <[email protected]>
…entation.go Co-authored-by: Tyler Yahn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr updates otltracegrpc for checking if the operation is enabled before adding any metric or performing operation.
tracked in #7800