-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Validate OTLP gRPC endpoint does not include path #7836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
While this validation makes sense, the approach taken is really hard to read and doesn't follow the common Go patterns. |
Thanks for the review. Please let me know if any further changes are needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unix://foo/bar (where the bar is the path here) is a valid gRPC endpoint. While I am not sure whether the current implementation supports unix, I am not sure this PR puts unix support in the right direction.
Related:
| return otlptrace.NewUnstarted(NewClient(opts...)) | ||
| } | ||
|
|
||
| func validateGRPCEndpontFromEnv() error { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure it is necessary to validate a grpc endpoint by ourselves. Should we just pass it to the gRPC client and let it decide?
What
Why
How
Tests