Skip to content

sdk/log/observ: guard LogProcessed with Enabled #7848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NesterovYehor wants to merge 2 commits into
base: main
Choose a base branch
from
+3 −1
Open

sdk/log/observ: guard LogProcessed with Enabled #7848

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aba8c6e
sdk/log/observ: guard LogProcessed with Enabled
NesterovYehor Jan 29, 2026
4954cde
Merge branch 'main' into logs-observ-guard-enabled
NesterovYehor Jan 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion sdk/log/internal/observ/simple_log_processor.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,9 @@ func NewSLP(id int64) (*SLP, error) {
// LogProcessed records that a log has been processed by the SimpleLogProcessor.
// If err is non-nil, it records the processing error as an attribute.
func (slp *SLP) LogProcessed(ctx context.Context, err error) {
slp.processed.Add(ctx, 1, slp.addOption(err)...)
if slp.processed.Enabled(ctx) {
slp.processed.Add(ctx, 1, slp.addOption(err)...)
}
}

func (slp *SLP) addOption(err error) []metric.AddOption {
Expand Down