[Prototype] attribute: Value.UnsafeAsSlice#7949
Draft
pellared wants to merge 10 commits intoopen-telemetry:mainfrom
Draft
[Prototype] attribute: Value.UnsafeAsSlice#7949pellared wants to merge 10 commits intoopen-telemetry:mainfrom
pellared wants to merge 10 commits intoopen-telemetry:mainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7949 +/- ##
=====================================
Coverage 81.7% 81.7%
=====================================
Files 304 304
Lines 23287 23363 +76
=====================================
+ Hits 19039 19110 +71
- Misses 3862 3865 +3
- Partials 386 388 +2
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
d85e2dd
This would be very useful for the SDK to implement attribute limits so that we do not have heap allocations when introspecting the attributes.
Credits to @dashpole for the idea/proposal.