Skip to content

fix(collector): resolve a typo in the resource limits warning message #1636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
TylerHelmuth merged 11 commits into from
May 12, 2025
Merged

fix(collector): resolve a typo in the resource limits warning message #1636

TylerHelmuth merged 11 commits into from
May 12, 2025

Conversation

@nialdaly
Copy link
Contributor

@nialdaly nialdaly commented Apr 17, 2025

Summary

  • This PR adds a small fix to resolve a typo in the resource limits warning message.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Apr 17, 2025 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@nialdaly nialdaly changed the title fix(collector): resolve a typo in the resource limits warning message Resolve a typo in the resource limits warning message Apr 17, 2025
TylerHelmuth
TylerHelmuth reviewed Apr 18, 2025
View reviewed changes
Copy link
Member

@TylerHelmuth TylerHelmuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please create separate PRs for each chart

@nialdaly nialdaly force-pushed the fix/collector-resource-limits-warning branch from 93dda8f to 9c7707a Compare April 18, 2025 21:10
@nialdaly nialdaly changed the title Resolve a typo in the resource limits warning message fix(collector): resolve a typo in the resource limits warning message Apr 18, 2025
@nialdaly nialdaly requested a review from TylerHelmuth April 19, 2025 12:28
@github-actions
Copy link
Contributor

github-actions bot commented May 8, 2025

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label May 8, 2025
@dmitryax
Copy link
Member

dmitryax commented May 8, 2025

Even a small change like this requires a version bump

@github-actions github-actions bot removed the Stale label May 9, 2025
@nialdaly nialdaly closed this May 9, 2025
@nialdaly nialdaly force-pushed the fix/collector-resource-limits-warning branch from e7b706c to 3d8ed91 Compare May 9, 2025 19:54
@nialdaly nialdaly reopened this May 9, 2025
@TylerHelmuth TylerHelmuth merged commit fbbc1ce into open-telemetry:main May 12, 2025
7 checks passed
@nialdaly nialdaly deleted the fix/collector-resource-limits-warning branch May 12, 2025 20:36
@nialdaly
Copy link
Contributor Author

nialdaly commented May 12, 2025

Thanks! @TylerHelmuth

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TylerHelmuth TylerHelmuth TylerHelmuth approved these changes

@Allex1 Allex1 Awaiting requested review from Allex1

@dmitryax dmitryax Awaiting requested review from dmitryax dmitryax is a code owner

@povilasv povilasv Awaiting requested review from povilasv povilasv is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nialdaly @dmitryax @TylerHelmuth