RPC stable opt-in #15879
Open
RPC stable opt-in #15879
+3,635
−2,671
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds support for stable RPC semantic conventions following the existing database/code semconv stability pattern. Users can now opt in to stable RPC conventions using OTEL_SEMCONV_STABILITY_OPT_IN=rpc (or rpc/dup for dual emission). Key changes: - Add rpc/rpc/dup config support to SemconvStability - Implement dual histogram metrics (ms→s unit conversion) - Add system name mappings (apache_dubbo→dubbo, connect_rpc→connectrpc) - Support new fully-qualified method format (service/method) - Convert status codes from Long to String format - Update metadata prefixes (rpc.grpc.request.metadata→rpc.request.metadata) - Add error.type attribute for stable semconv - Create RpcSemconvStabilityUtil test helper
This reverts commit 851bd4d.
zeitlinger
force-pushed
the
rpc-opt-in
branch
from
7ef1f30 to
d48324a
Compare
Member
|
@zeitlinger can you find ways to split this up into smaller pieces? |
Member
Author
good question - it's mostly tests, but adding those later will only reduce test coverage in the meantime. Do you have an idea? |
Member
|
you can see how I've broken out the database semconv stabilization tasks in #12608 in case that helps |
Member
Author
Member
|
can you split the semconv changes up instead of implementing all of the changes in one PR? |
Member
yeah, this sounds like a good option, then you could even split the tests and send only grpc test first for example |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15871