Stabilize complex attributes #7973

trask · 2026-01-09T20:46:09Z

No description provided.

codecov · 2026-01-09T22:44:02Z

Codecov Report

❌ Patch coverage is 84.76562% with 39 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.21%. Comparing base (c8ba093) to head (99bb2f1).

Files with missing lines	Patch %	Lines
...java/io/opentelemetry/api/common/JsonEncoding.java	73.61%	15 Missing and 4 partials ⚠️
...metry/api/common/ArrayBackedAttributesBuilder.java	90.16%	2 Missing and 4 partials ⚠️
...c/main/java/io/opentelemetry/api/common/Empty.java	0.00%	5 Missing ⚠️
...pentelemetry/api/common/ArrayBackedAttributes.java	92.85%	2 Missing and 2 partials ⚠️
...n/java/io/opentelemetry/api/common/ValueEmpty.java	62.50%	3 Missing ⚠️
...lemetry/exporter/zipkin/EventDataToAnnotation.java	75.00%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #7973      +/-   ##
============================================
+ Coverage     90.17%   90.21%   +0.04%     
- Complexity     7479     7600     +121     
============================================
  Files           834      838       +4     
  Lines         22540    22787     +247     
  Branches       2236     2271      +35     
============================================
+ Hits          20326    20558     +232     
- Misses         1511     1516       +5     
- Partials        703      713      +10

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

trask · 2026-01-09T20:47:27Z

api/all/src/main/java/io/opentelemetry/api/common/ArrayBackedAttributes.java

changes copy-pasted from ExtendedArrayBackedAttributes.java

trask · 2026-01-09T20:47:43Z

api/all/src/main/java/io/opentelemetry/api/common/ArrayBackedAttributesBuilder.java

changes copy-pasted from ExtendedArrayBackedAttributesBuilder.java

trask · 2026-01-09T20:48:27Z

api/all/src/main/java/io/opentelemetry/api/common/AttributeKey.java

changes copy-pasted from ExtendedAttributeKey.java

trask · 2026-01-09T20:49:16Z

api/all/src/main/java/io/opentelemetry/api/common/Attributes.java

changes copy-pasted from ExtendedAttributes.java

trask · 2026-01-09T20:49:40Z

api/all/src/main/java/io/opentelemetry/api/common/AttributesBuilder.java

changes copy-pasted from ExtendedAttributesBuilder.java

Is your plan to keeep ExtendedAttributes around for a couple of releases to give folks a chance to migrate gracefully?

yeah, good point, deprecated them in c133eea

oh no, that spun out of control due to suppressing usages, reverted, I'd suggest that I do that as a follow-up PR

leaving this discussion open so I don't forget

api/all/src/main/java/io/opentelemetry/api/common/Value.java

api/all/src/main/java/io/opentelemetry/api/common/ValueEmpty.java

...s/zipkin/src/test/java/io/opentelemetry/exporter/zipkin/OtelToZipkinSpanTransformerTest.java

api/all/src/main/java/io/opentelemetry/api/common/ValueEmpty.java

api/all/src/main/java/io/opentelemetry/api/common/Value.java

api/all/src/test/java/io/opentelemetry/api/common/ValueToProtoJsonTest.java

This reverts commit c133eea.

api/all/src/main/java/io/opentelemetry/api/common/ProtoJson.java

jack-berg · 2026-01-23T19:00:11Z

api/all/src/main/java/io/opentelemetry/api/common/JsonEncoding.java

+    }
+  }
+
+  private static void appendString(StringBuilder sb, String value) {


Is the logic here based on any sort of reference or specification you can link to? Trying to get a sense of how to evaluate it for completeness / correctness.

https://datatracker.ietf.org/doc/html/rfc8259

Thanks. Here's the relevant section: https://datatracker.ietf.org/doc/html/rfc8259#section-7

jack-berg · 2026-01-23T19:04:05Z

api/all/src/main/java/io/opentelemetry/api/common/ProtoJson.java

+
+  private static void appendBytes(StringBuilder sb, ByteBuffer value) {
+    byte[] bytes = new byte[value.remaining()];
+    value.duplicate().get(bytes);


We shouldn't need to duplicate this since ValueBytes.create already copies the array, so it should be strictly read only / immutable here.

jack-berg · 2026-01-23T19:05:39Z

api/all/src/main/java/io/opentelemetry/api/common/Value.java

-   * Return a string encoding of this {@link Value}. This is intended to be a fallback serialized
-   * representation in case there is no suitable encoding that can utilize {@link #getType()} /
-   * {@link #getValue()} to serialize specific types.
+   * Returns a string representation of this {@link Value}.


Nice javadoc here!

jack-berg · 2026-01-23T19:08:25Z

api/all/src/main/java/io/opentelemetry/api/common/ValueArray.java

-    return value.stream().map(Value::asString).collect(joining(", ", "[", "]"));
+    StringBuilder sb = new StringBuilder();
+    ProtoJson.append(sb, this);
+    return sb.toString();


Could add a helper to ProtoJson to avoid duplicating logic in the Value implementation classes:

static String asString(Value<?> value) { StringBuilder sb = new StringBuilder(); append(sb, value); return sb.toString(); }

Then every asString() implementation just looks like:

@Override public String asString() { return ProtoJson.asString(this); }

Oh wait, I see. Its the difference between the top level representation. I still think you could centralize the logic all in ProtoJson by adding a int level parameter to append and changing the logic based on whether the level was 0 or non-0. Something like the following, demonstrated on DOUBLE but applicable to all the types:

static void append(StringBuilder sb, Value<?> value, int level) { switch (value.getType()) { case DOUBLE: appendDouble(sb, (Double) value.getValue(), /*wrapWithQuotes*/ level > 0); break; // other cases omitted for brevity } } private static void appendDouble(StringBuilder sb, double value, boolean wrapWithQuotes) { if (wrapWithQuotes) { sb.append('"'); } if (Double.isNaN(value)) { sb.append("NaN"); } else if (Double.isInfinite(value)) { sb.append(value > 0 ? "Infinity" : "-Infinity"); } else { sb.append(value); } if (wrapWithQuotes) { sb.append('"'); } }

seems more complicated to me, but can apply this pattern if you prefer

Nah you can ignore this if you like the way it is. I don't like the duplicate logic, but my suggestion is crufty. Maybe I'll go back and see if there's a cleaner way to DRY it up post merge.

jack-berg

Just minor comments at this point that don't affect the public API

…ttributes-try-2

trask added 2 commits January 9, 2026 14:31

Stabilize complex attributes

eca5ee4

apidiffs

8c951bd

trask force-pushed the stabilize-complex-attributes-try-2 branch from 3bc8e76 to 8c951bd Compare January 9, 2026 22:32

updates

0e2af07

trask force-pushed the stabilize-complex-attributes-try-2 branch from 30fb180 to 0e2af07 Compare January 9, 2026 23:37

json

103d13b

trask force-pushed the stabilize-complex-attributes-try-2 branch 4 times, most recently from 55d9121 to 23f5d22 Compare January 10, 2026 04:05

toProtoJson

0e19885

trask force-pushed the stabilize-complex-attributes-try-2 branch from 23f5d22 to 0e19885 Compare January 10, 2026 04:15

trask commented Jan 10, 2026

View reviewed changes

trask marked this pull request as ready for review January 10, 2026 04:16

trask requested a review from a team as a code owner January 10, 2026 04:16

trask added 2 commits January 10, 2026 09:35

unit tests

0ad0d89

test coverage

3b6a906

jack-berg reviewed Jan 15, 2026

View reviewed changes

api/all/src/test/java/io/opentelemetry/api/common/ValueToProtoJsonTest.java Outdated Show resolved Hide resolved

jack-berg reviewed Jan 15, 2026

View reviewed changes

api/all/src/test/java/io/opentelemetry/api/common/ValueToProtoJsonTest.java Outdated Show resolved Hide resolved

trask added 9 commits January 19, 2026 19:05

improve javadoc

bc77eed

better empty value representation

543e8eb

deprecate extended attributes incubating api

c133eea

Use asString instead of toProtoJson

3a8b796

parameterized test

4fbab35

Revert "deprecate extended attributes incubating api"

7604d83

This reverts commit c133eea.

fixup! Use asString instead of toProtoJson

fd5fa9d

fixup! Use asString instead of toProtoJson

facd585

Update to latest spec PR

2a8fd46

trask force-pushed the stabilize-complex-attributes-try-2 branch from 7dabd12 to 2a8fd46 Compare January 21, 2026 23:30

trask added 3 commits January 21, 2026 18:41

jApiCmp

83dd600

Fix Nan, Infinity, -Infinity

04c4a6f

update javadoc

a98199a

trask force-pushed the stabilize-complex-attributes-try-2 branch from 9f18eb0 to a98199a Compare January 22, 2026 15:58

fixup! Fix Nan, Infinity, -Infinity

d31abc4

jack-berg reviewed Jan 23, 2026

View reviewed changes

api/all/src/main/java/io/opentelemetry/api/common/ProtoJson.java Outdated Show resolved Hide resolved

jack-berg reviewed Jan 23, 2026

View reviewed changes

jack-berg approved these changes Jan 23, 2026

View reviewed changes

trask added 3 commits January 26, 2026 18:54

Merge remote-tracking branch 'upstream/main' into stabilize-complex-a…

aa0b3e4

…ttributes-try-2

rename ProtoJson to JsonEncoding

cdd9ada

remove ByteBuffer duplicate

99bb2f1

jack-berg mentioned this pull request Jan 27, 2026

Support semconv attributes of type any open-telemetry/semantic-conventions-java#385

Open

Stabilize complex attributes #7973

Are you sure you want to change the base?

Stabilize complex attributes #7973

Uh oh!

Conversation

trask commented Jan 9, 2026

Uh oh!

codecov bot commented Jan 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jack-berg Jan 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jack-berg left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

codecov bot commented Jan 9, 2026 •

edited

Loading

jack-berg Jan 23, 2026 •

edited

Loading