Skip to content

Conversation

@rlj1202
Copy link

@rlj1202 rlj1202 commented Nov 7, 2025

Which problem is this PR solving?

On ESM environment where ECMAScript module and CommonJS modules coexist, unnecessary module preload warning logs appear.

How Has This Been Tested?

Example:

graph TD;
    main.mjs-->a.mjs;
    main.mjs-->b.cjs;
    main.mjs-->d.mjs;
    main.mjs-->e.cjs;
    b.cjs-->c.cjs;
    e.cjs-->f.cjs;
Loading
  1. main.mjs visited, b.cjs and e.cjs appear in the require.cache as loaded = false
  2. a.mjs visited and loaded
  3. b.cjs visited, c.cjs appears in the require.cache as loaded = false
  4. c.cjs visited and loaded
  5. b.cjs loaded
  6. d.mjs visited and loaded
  7. e.cjs visited, f.cjs appears in the require.cache as loaded = false
  8. f.cjs visited and loaded
  9. e.cjs loaded
  10. main.mjs loaded
~/projects/stackblitz-starters-oejjyprq
❯ npm start

> start
> node main.mjs

/home/projects/stackblitz-starters-oejjyprq/a.mjs
/home/projects/stackblitz-starters-oejjyprq/c.cjs [
  [ '/home/projects/stackblitz-starters-oejjyprq/b.cjs', false ],
  [ '/home/projects/stackblitz-starters-oejjyprq/e.cjs', false ],
  [ '/home/projects/stackblitz-starters-oejjyprq/c.cjs', false ]
]
/home/projects/stackblitz-starters-oejjyprq/b.cjs [
  [ '/home/projects/stackblitz-starters-oejjyprq/b.cjs', false ],
  [ '/home/projects/stackblitz-starters-oejjyprq/e.cjs', false ],
  [ '/home/projects/stackblitz-starters-oejjyprq/c.cjs', true ]
]
/home/projects/stackblitz-starters-oejjyprq/d.mjs
/home/projects/stackblitz-starters-oejjyprq/f.cjs [
  [ '/home/projects/stackblitz-starters-oejjyprq/b.cjs', true ],
  [ '/home/projects/stackblitz-starters-oejjyprq/e.cjs', false ],
  [ '/home/projects/stackblitz-starters-oejjyprq/c.cjs', true ],
  [ '/home/projects/stackblitz-starters-oejjyprq/f.cjs', false ]
]
/home/projects/stackblitz-starters-oejjyprq/e.cjs [
  [ '/home/projects/stackblitz-starters-oejjyprq/b.cjs', true ],
  [ '/home/projects/stackblitz-starters-oejjyprq/e.cjs', false ],
  [ '/home/projects/stackblitz-starters-oejjyprq/c.cjs', true ],
  [ '/home/projects/stackblitz-starters-oejjyprq/f.cjs', true ]
]

So to warn preloaded modules properly in ESM environment, Module.loaded property should be considered.

Checklist:

  • Followed the style guidelines of this project
  • Unit tests have been added (N/A)
  • Documentation has been updated (N/A)

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 7, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: rlj1202 / name: Jisu Sim (7cbc531)

@rlj1202 rlj1202 force-pushed the chore/warn-on-preloaded-modules branch 2 times, most recently from b755cfa to 8ae3980 Compare November 7, 2025 16:29
@rlj1202 rlj1202 changed the title chore(opentelemetry-instrumentation): improve _warnOnPreloadedModules function not to show warning logs when the module is not marked as loaded chore(opentelemetry-instrumentation): improve _warnOnPreloadedModules function not to show warning logs when the module is not marked as loaded Nov 7, 2025
@rlj1202 rlj1202 force-pushed the chore/warn-on-preloaded-modules branch from 8ae3980 to caab4e6 Compare November 7, 2025 16:31
@rlj1202 rlj1202 marked this pull request as ready for review November 7, 2025 17:19
@rlj1202 rlj1202 requested a review from a team as a code owner November 7, 2025 17:19
@codecov
Copy link

codecov bot commented Nov 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.16%. Comparing base (f6c2f62) to head (caab4e6).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6095   +/-   ##
=======================================
  Coverage   95.16%   95.16%           
=======================================
  Files         316      316           
  Lines        9220     9220           
  Branches     2080     2080           
=======================================
  Hits         8774     8774           
  Misses        446      446           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

… function not to show warning logs when the module is not marked as loaded
@rlj1202 rlj1202 force-pushed the chore/warn-on-preloaded-modules branch from caab4e6 to 7cbc531 Compare November 15, 2025 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant