## Summary - propagate through recursive calls - add regression test covering ancestor id optimization ## Context Fixes #6323. When , ancestor ids were not used in the computed XPath due to a false value in recursive calls. ## Test plan - [ ] npm test -- packages/opentelemetry-sdk-trace-web/test/window/utils.test.ts#6334
Closed
Terrorizer-AI wants to merge 1 commit intoopen-telemetry:mainfrom
Closed
## Summary
- propagate through recursive calls
- add regression test covering ancestor id optimization
## Context
Fixes #6323. When , ancestor ids were not used in the
computed XPath due to a false value in recursive calls.
## Test plan
- [ ] npm test -- packages/opentelemetry-sdk-trace-web/test/window/utils.test.ts#6334Terrorizer-AI wants to merge 1 commit intoopen-telemetry:mainfrom
Terrorizer-AI wants to merge 1 commit intoopen-telemetry:mainfrom
Conversation
Pass the optimised flag through recursive getElementXPath calls so ancestor ids are used consistently, and add a regression test for it. Fixes open-telemetry#6323.
|
|
overbalance
requested changes
Jan 24, 2026
Contributor
overbalance
left a comment
overbalance
left a comment
There was a problem hiding this comment.
Should we block this robot? Does GitHub have that function?
|
yaa its my AI Agent , sorry for that. @overbalance . |
Member
|
Closing this as it is superseded by #6335. This seems like it was a mistake, so I suggest we don’t take any further action here for now. FYI @akkupratap323, our GenAI policy: https://github.com/open-telemetry/community/blob/096526e65c72e0850e67f21034c394d9da974422/policies/genai.md |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
optimisedthrough recursivegetElementXPathcallsContext
Fixes #6323. When
optimised=true, ancestor ids were not used in thecomputed XPath due to a false value in recursive calls.
Test plan