fix: cancel retries on shutdown#6340
Draft
pichlermarc wants to merge 5 commits intoopen-telemetry:mainfrom
Draft
fix: cancel retries on shutdown#6340pichlermarc wants to merge 5 commits intoopen-telemetry:mainfrom
pichlermarc wants to merge 5 commits intoopen-telemetry:mainfrom
Conversation
This was referenced Jan 29, 2026
Member
Author
|
I'm spinning off mutiple PRs from this one, the first one is #6356 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
With the fix from #6147, we started re-trying failed exports more aggressively. The result is that shutdown now hangs for a couple of seconds before it finishes. (ref: open-telemetry/opentelemetry-js-contrib#3349)
This PR introduces several changes to address this:
exporter.forceFlush()is calledBatchSpanProcessor#shutdown()now schedules exports, but callsSpanExporter#forceFlush()right after scheduling the export, signaling the exporter to speed upBatchLogRecordProcessor#shutdown()does the samePeriodicExportingMetricReader#shutdown()does the sameThe diff for this is fairly large, and I don't expect anybody to review this PR, so I'll break this down into smaller chunks, keeping this PR in draft to show all changes working together.
Type of change
How Has This Been Tested?
@opentelemetry/sdk-nodeto test the same shutdown code path used in@opentelemetry/auto-instrumentation-node