fix(sdk-trace-web): pass optimised parameter recursively in getElementXPath#6346
Open
RIT2006ESH wants to merge 1 commit intoopen-telemetry:mainfrom
Open
fix(sdk-trace-web): pass optimised parameter recursively in getElementXPath#6346RIT2006ESH wants to merge 1 commit intoopen-telemetry:mainfrom
RIT2006ESH wants to merge 1 commit intoopen-telemetry:mainfrom
Conversation
…tXPath The getElementXPath function was not passing the optimised parameter recursively when traversing parent nodes. This caused child elements of parents with IDs to get full paths instead of optimised paths using the parent's ID. Fixes open-telemetry#6323 Signed-off-by: rino_303 <singhritesh31836@gmail.com>
|
|
Contributor
|
This fix is already in progress: #6335 |
Author
|
Sir can u pls guide me on what are the issues that I could contribute in as I am new in open source contribution as I am trying for GSOC...It will really be helpful... |
Contributor
|
@RIT2006ESH Appreciate your desire to contribute! I don't see any "good first tickets" at the moment, but take a look through https://github.com/open-telemetry/opentelemetry-js/issues and see if there's anything that you can start solving. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
getElementXPathfunction was not passing theoptimisedparameter recursively when traversing parent nodes. This caused child elements of parents with IDs to get full paths (e.g.,//html/body/div) instead of optimised paths using the parent's ID (e.g.,//*[@id="parent-id"]/div).Changes
getElementXPathto passoptimisedinstead offalseFix
Fixes #6323