refactor(sdk-logs): remove unnecessary closure in _maybeStartTimer()#6361
Closed
cjihrig wants to merge 2 commits intoopen-telemetry:mainfrom
Closed
refactor(sdk-logs): remove unnecessary closure in _maybeStartTimer()#6361cjihrig wants to merge 2 commits intoopen-telemetry:mainfrom
_maybeStartTimer()#6361cjihrig wants to merge 2 commits intoopen-telemetry:mainfrom
Conversation
cjihrig
commented
Feb 1, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6361 +/- ##
=======================================
Coverage 95.48% 95.48%
=======================================
Files 363 363
Lines 11564 11564
Branches 2669 2669
=======================================
Hits 11042 11042
Misses 522 522
🚀 New features to boost your workflow:
|
Contributor
Author
|
Oh, it looks like this won't be necessary with #6356. I'll close this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
_maybeStartTimer()creates an unnecessary closure in order to invokeflush()from a timer. This creates unnecessary overhead at runtime.Fixes # N/A
Short description of the changes
This commit removes the unnecessary closure.
Type of change
Perf refactor
How Has This Been Tested?
Checklist: