fix(api): Update DiagLogger to use original console methods#6395
Open
martinkuba wants to merge 3 commits intoopen-telemetry:mainfrom
Open
fix(api): Update DiagLogger to use original console methods#6395martinkuba wants to merge 3 commits intoopen-telemetry:mainfrom
martinkuba wants to merge 3 commits intoopen-telemetry:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6395 +/- ##
=======================================
Coverage 95.50% 95.50%
=======================================
Files 365 365
Lines 11609 11618 +9
Branches 2677 2680 +3
=======================================
+ Hits 11087 11096 +9
Misses 522 522
🚀 New features to boost your workflow:
|
martinkuba
commented
Feb 11, 2026
| if (typeof theFunc !== 'function') { | ||
| theFunc = _originalConsoleMethods['log']; | ||
| } | ||
| // Fall back in case console was not available at module load time but became available later. |
Contributor
Author
There was a problem hiding this comment.
@pichlermarc This is related to the comment above about console available only when developer console is open. I think this would happen only in some very old browsers like IE. We only support modern browsers, so this is purely defensive. But the logic was already there before this change (comment on line 65).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
In the browser repo, we are introducing an instrumentation for capturing console logs. There is an issue with the diagnostics logger - capturing console logs triggers work by the SDK, which may generate console logs using the diagnostics logger, which creates more work by the SDK ... infinite loop.
The issue has been discussed here.
This is an alternative fix to #6355
Short description of the changes
The original console methods are saved at module load time in DiagConsoleLogger. This prevents diagnostic log calls
from being re-captured as telemetry.
Type of change
Please delete options that are not relevant.
Checklist: