Skip to content

fix(otlp-exporter-base): handle response error event #6412

Open
pichlermarc wants to merge 5 commits intoopen-telemetry:mainfrom
dynatrace-oss-contrib:fix/http-exporter-error-event
Open

fix(otlp-exporter-base): handle response error event #6412
pichlermarc wants to merge 5 commits intoopen-telemetry:mainfrom
dynatrace-oss-contrib:fix/http-exporter-error-event

Conversation

@pichlermarc
Copy link
Member

@pichlermarc pichlermarc commented Feb 16, 2026

Which problem is this PR solving?

See #6410, the error event on the response is unhandled, it may be triggered in certain cases, like the author describes. This PR fixes this by adding a test + handling the response. In these cases we should already have the headers, so I added handling for sucess/failure/retry based on that, even if the response was not fully received (since the response is not necessary to ensure the OTLP export remains functional)

Fixes #6410

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Added unit tests

@pichlermarc pichlermarc requested a review from a team as a code owner February 16, 2026 11:14
@pichlermarc pichlermarc marked this pull request as draft February 16, 2026 11:14
@pichlermarc pichlermarc changed the title fix(otlp-exporter-base): handle fix(otlp-exporter-base): handle response error event Feb 16, 2026
@codecov
Copy link

codecov bot commented Feb 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.59%. Comparing base (34e7d91) to head (f4bc454).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6412   +/-   ##
=======================================
  Coverage   95.59%   95.59%           
=======================================
  Files         361      361           
  Lines       11595    11602    +7     
  Branches     2683     2686    +3     
=======================================
+ Hits        11084    11091    +7     
  Misses        511      511           
Files with missing lines Coverage Δ
...xporter-base/src/transport/http-transport-utils.ts 94.91% <100.00%> (+0.68%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pichlermarc pichlermarc force-pushed the fix/http-exporter-error-event branch from 87232d1 to 13b3bc4 Compare February 16, 2026 11:24
@pichlermarc pichlermarc marked this pull request as ready for review February 16, 2026 12:20
@pichlermarc pichlermarc force-pushed the fix/http-exporter-error-event branch from 9947056 to 37968e5 Compare February 16, 2026 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing res.on('error') handler in HTTP transport causes uncaughtException on ECONNRESET

2 participants

Comments