Skip to content

Refactor options handling for fetch request #6422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dalechyn wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −1
Open

Refactor options handling for fetch request #6422

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion experimental/packages/opentelemetry-instrumentation-fetch/src/fetch.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -420,7 +420,9 @@ export class FetchInstrumentation extends InstrumentationBase<FetchInstrumentati
args[0] instanceof Request ? args[0].url : String(args[0])
).href;

const options = args[0] instanceof Request ? args[0] : args[1] || {};
const options = args[0] instanceof Request
? new Request(args[0], args[1])
: { url: args[0], ...args[1] };
Comment on lines +423 to +425
Copy link

Copilot AI Feb 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are no tests covering the scenario where both a Request object and a RequestInit object are passed to fetch (e.g., fetch(new Request(...), requestInit)). This is the exact issue mentioned in #6421. Tests should be added to verify that the RequestInit options properly override or extend the Request object's properties, as per the Fetch API specification.

Suggested change
const options = args[0] instanceof Request
? new Request(args[0], args[1])
: { url: args[0], ...args[1] };
const options =
args[0] instanceof Request
? new Request(args[0], args[1])
: new Request(args[0] as RequestInfo, args[1]);

Copilot uses AI. Check for mistakes.
Copy link

Copilot AI Feb 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The url property should not be added to the options object when args[0] is not a Request instance. The RequestInit interface doesn't include a url property, and adding it could cause issues when the options object is passed to user hooks or the original fetch API. The line should be args[1] || {} instead of { url: args[0], ...args[1] }.

Suggested change
: { url: args[0], ...args[1] };
: (args[1] || {});

Copilot uses AI. Check for mistakes.
const createdSpan = plugin._createSpan(url, options);
if (!createdSpan) {
return original.apply(this, args);
Expand Down