Stop using "any" as propagator generic - #6903
Conversation
|
Welcome, contributor! Thank you for your contribution to opentelemetry-js. Important reminders:
|
f096a67 to
2cc99ec
Compare
2cc99ec to
32070d8
Compare
Pull request dashboard statusWaiting on reviewers · refreshed 2026-07-30 13:48 UTC Review the latest changes. Status above doesn't look right?
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6903 +/- ##
==========================================
- Coverage 95.08% 95.07% -0.01%
==========================================
Files 394 394
Lines 13997 14016 +19
Branches 3224 3227 +3
==========================================
+ Hits 13309 13326 +17
- Misses 688 690 +2
🚀 New features to boost your workflow:
|
The current implementation of the
httpinstrumentation incorrectly assumes that a request headers is always an object. However, NodeJS also allows using an array of strings asrequest.headers.The
anygeneric of the propagator classes hides the typing error this should normally generate:This PR fixes several things:
anyas it may cause invisible issues