Skip to content

fix(sdk-node): support headers_list for log exporters - #6955

Open
LarryHu0217 wants to merge 2 commits into
open-telemetry:mainfrom
LarryHu0217:codex/sdk-node-headers-list-6953
Open

fix(sdk-node): support headers_list for log exporters#6955
LarryHu0217 wants to merge 2 commits into
open-telemetry:mainfrom
LarryHu0217:codex/sdk-node-headers-list-6953

Conversation

@LarryHu0217

Copy link
Copy Markdown
Contributor

Fixes #6953

Changes

  • parse declarative headers_list values using the existing percent-decoding key/value parser
  • merge explicit headers over headers_list, preserving the documented precedence
  • apply the merged values to HTTP headers and gRPC metadata for log exporters
  • mark headers_list as handled during exporter creation

Testing

  • focused sdk-node create-from-config and utils tests: 93 passing
  • sdk-node ESLint
  • strict no-emit TypeScript check for the touched header utility
  • git diff --check

Signed-off-by: Liang Hu <lh3057@columbia.edu>
@LarryHu0217
LarryHu0217 requested a review from a team as a code owner July 28, 2026 16:02
Signed-off-by: Liang Hu <lh3057@columbia.edu>
@codecov

codecov Bot commented Jul 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.07%. Comparing base (636e27a) to head (55c168c).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6955   +/-   ##
=======================================
  Coverage   95.07%   95.07%           
=======================================
  Files         409      409           
  Lines       14256    14256           
  Branches     3267     3267           
=======================================
  Hits        13554    13554           
  Misses        702      702           
Files with missing lines Coverage Δ
...s/opentelemetry-sdk-node/src/create-from-config.ts 95.42% <ø> (ø)
...ental/packages/opentelemetry-sdk-node/src/utils.ts 97.20% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@opentelemetry-pr-dashboard

opentelemetry-pr-dashboard Bot commented Jul 28, 2026

Copy link
Copy Markdown

Pull request dashboard status

Waiting on reviewers · refreshed 2026-07-30 13:48 UTC

Review the latest changes.

Status above doesn't look right?
  • Just replied or pushed? Anything around or after the refresh time above may not be picked up yet — give it a few minutes.
  • Anything look wrong? Report it with what you expected; it helps us improve the dashboard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[sdk-node] support headers_list when creating SDK exporters from declarative configuration

1 participant