Skip to content

fix(sdk-trace-base): avoid webpack CommonJS self-reference #6982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sansynx wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix(sdk-trace-base): avoid webpack CommonJS self-reference #6982

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4f68e1f
fix(sdk-trace-base): avoid webpack CommonJS self-reference
sansynx Aug 6, 2026
d44a01f
Potential fix for pull request finding
sansynx Aug 6, 2026
05b7b76
test(bundlers): split sdk-node webpack fixture
sansynx Aug 6, 2026
8df7397
fix: address review feedback on webpack regression
sansynx Aug 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@ For notes on migrating to 2.x / 0.200.x see [the upgrade guide](doc/upgrade-to-2

### :bug: Bug Fixes

* fix(sdk-trace-base): avoid a Webpack self-reference error in CommonJS output @sansynx
Comment thread
sansynx marked this conversation as resolved.
Outdated

### :books: Documentation

### :house: Internal
Expand Down
1 change: 1 addition & 0 deletions bundler-tests/node/webpack-5/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
"@opentelemetry/resources": "file:../../../packages/opentelemetry-resources",
"@opentelemetry/sdk-logs": "file:../../../experimental/packages/sdk-logs",
"@opentelemetry/sdk-metrics": "file:../../../packages/sdk-metrics",
"@opentelemetry/sdk-node": "file:../../../experimental/packages/opentelemetry-sdk-node",
"@opentelemetry/sdk-trace": "file:../../../packages/sdk-trace"
},
"devDependencies": {
Expand Down
6 changes: 5 additions & 1 deletion bundler-tests/node/webpack-5/src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ const {
const { B3Propagator } = require('@opentelemetry/propagator-b3');
const { defaultServiceName } = require('@opentelemetry/resources');
const { MeterProvider } = require('@opentelemetry/sdk-metrics');
import { NodeSDK } from '@opentelemetry/sdk-node';
const { TracerProvider } = require('@opentelemetry/sdk-trace');

diag.setLogger({
Expand All @@ -27,7 +28,9 @@ diag.setLogger({

logs.setGlobalLoggerProvider(
new LoggerProvider({
processors: [new SimpleLogRecordProcessor({ exporter: new OTLPLogExporter() })],
processors: [
new SimpleLogRecordProcessor({ exporter: new OTLPLogExporter() }),
],
})
);

Expand All @@ -46,6 +49,7 @@ class TestInstrumentation extends InstrumentationBase {
new TestInstrumentation('test', '0.0.0');
new TracerProvider();
new MeterProvider();
new NodeSDK();
new OTLPTraceExporter();
new OTLPMetricExporter();
new W3CTraceContextPropagator();
Expand Down
4 changes: 4 additions & 0 deletions bundler-tests/node/webpack-5/webpack.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,10 @@ export default {
mode: 'production',
entry: './src/index.js',
target: 'node',
resolve: {
mainFields: ['main'],
},
ignoreWarnings: [/Critical dependency/],
output: {
filename: 'bundle.js',
path: path.resolve(__dirname, 'dist'),
Expand Down
6 changes: 4 additions & 2 deletions packages/opentelemetry-sdk-trace-base/src/utility.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,10 @@
import type { TracerConfig } from './types-shim';
import { getNumberFromEnv } from '@opentelemetry/core';

export const DEFAULT_ATTRIBUTE_COUNT_LIMIT = 128;
export const DEFAULT_ATTRIBUTE_VALUE_LENGTH_LIMIT = Infinity;
const DEFAULT_ATTRIBUTE_COUNT_LIMIT = 128;
const DEFAULT_ATTRIBUTE_VALUE_LENGTH_LIMIT = Infinity;

export { DEFAULT_ATTRIBUTE_COUNT_LIMIT, DEFAULT_ATTRIBUTE_VALUE_LENGTH_LIMIT };

/**
* When general limits are provided and model specific limits are not,
Expand Down