Skip to content

Add bounding for OTLP response body #361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fractalwrench merged 3 commits into from
Apr 1, 2026
Merged

Add bounding for OTLP response body #361

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c28f36c
fix: add bounding for OTLP response body
fractalwrench Mar 31, 2026
106c66c
tweak response body limit
fractalwrench Mar 31, 2026
a9ddd89
Merge branch 'main' into fw/bound-response-body
fractalwrench Apr 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 18 additions & 4 deletions exporters-otlp/src/commonMain/kotlin/io/opentelemetry/kotlin/export/OtlpClient.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,13 @@ import io.ktor.client.plugins.compression.compress
import io.ktor.client.request.header
import io.ktor.client.request.post
import io.ktor.client.request.setBody
import io.ktor.client.statement.bodyAsBytes
import io.ktor.client.statement.HttpResponse
import io.ktor.client.statement.bodyAsChannel
import io.ktor.http.ContentType
import io.ktor.http.HttpHeaders
import io.ktor.http.contentType
import io.ktor.utils.io.readRemaining
import io.opentelemetry.kotlin.export.OtlpClient.Companion.MAX_ERROR_BODY_BYTES
import io.opentelemetry.kotlin.export.OtlpResponse.ClientError
import io.opentelemetry.kotlin.export.OtlpResponse.ServerError
import io.opentelemetry.kotlin.export.OtlpResponse.Success
Expand All @@ -20,13 +23,14 @@ import io.opentelemetry.kotlin.logging.model.ReadableLogRecord
import io.opentelemetry.kotlin.tracing.data.SpanData
import io.opentelemetry.kotlin.tracing.export.deserializeTraceRecordErrorMessage
import io.opentelemetry.kotlin.tracing.export.toProtobufByteArray
import kotlinx.io.readByteArray

internal class OtlpClient(
private val baseUrl: String,
private val httpClient: HttpClient = defaultHttpClient
) {

private val contentType = ContentType.Companion.parse("application/x-protobuf")
private val contentType = ContentType.parse("application/x-protobuf")
private val userAgent = "OTel-OTLP-Exporter-Kotlin/${BuildKonfig.VERSION}"

suspend fun exportLogs(telemetry: List<ReadableLogRecord>): OtlpResponse = exportTelemetry(
Expand Down Expand Up @@ -56,12 +60,22 @@ internal class OtlpClient(
}
when (val code = response.status.value) {
200 -> Success
in 400..499 -> ClientError(code, onError(response.bodyAsBytes()))
in 500..599 -> ServerError(code, onError(response.bodyAsBytes()))
in 400..499 -> ClientError(code, onError(response.boundedBodyBytes()))
in 500..599 -> ServerError(code, onError(response.boundedBodyBytes()))
else -> Unknown
}
} catch (ignored: HttpRequestTimeoutException) {
Unknown
}
}

/**
* Reads at most [MAX_ERROR_BODY_BYTES] from the response body.
*/
private suspend fun HttpResponse.boundedBodyBytes(): ByteArray =
bodyAsChannel().readRemaining(MAX_ERROR_BODY_BYTES).readByteArray()

private companion object {
const val MAX_ERROR_BODY_BYTES: Long = 4 * 1024 * 1024
}
}