-
Notifications
You must be signed in to change notification settings - Fork 7
Create Sampler API #51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create Sampler API #51
Conversation
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (50.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #51 +/- ##
==========================================
- Coverage 90.71% 90.60% -0.12%
==========================================
Files 214 215 +1
Lines 2295 2298 +3
Branches 233 233
==========================================
Hits 2082 2082
- Misses 160 163 +3
Partials 53 53 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
60b6e07 to
3792f75
Compare
bidetofevil
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Give how sampling should work on mobile apps without it being fragmented and biased (i.e. not per telemetry instance, but by app instance or install), it feels like this merits a bigger discussion to see if it makes sense to bake that into the API.
Thoughts?
|
Happy to discuss this. My first thoughts are that the Sampler API is a stable part of the OpenTelemetry specification and that this project also needs to support backend use-cases, not just mobile. IMO the |
bidetofevil
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I guess my main issue is whether the base API is sufficiently expressive and what Sampler implementations ought to be built initially. Both of these could be done after the core API is added.
Goal
Creates the interface that forms the public Sampler API. Currently there is no way to configure or use these symbols - that will happen in subsequent PRs.
Closes #34