-
Notifications
You must be signed in to change notification settings - Fork 7
Implement in-memory exporters for traces + logs #54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement in-memory exporters for traces + logs #54
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #54 +/- ##
==========================================
+ Coverage 90.65% 90.71% +0.06%
==========================================
Files 210 214 +4
Lines 2279 2295 +16
Branches 233 233
==========================================
+ Hits 2066 2082 +16
Misses 160 160
Partials 53 53 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
7c99a5a to
edad551
Compare
Msksgm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
bidetofevil
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be under a test source set? It doesn't feel like it is robust enough to be used for production given that the telemetry are kept in memory indefinitely, so it feels like it should either be strictly for testing, or need a bit more safety around it to prevent it being a memory-leaking foot-gun
edad551 to
f32e0c8
Compare
|
@bidetofevil how about providing them in a separate module named something like |
|
Anything that makes it clear they aren't intended for production usage would work for me. |
f32e0c8 to
c64c454
Compare
|
Moved the classes to a separate module. |
bidetofevil
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Msksgm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Goal
Implements an in-memory exporter for span + log objects. Closes #39.
Testing
Added unit tests.