Skip to content

Conversation

@fractalwrench
Copy link
Member

Goal

Implements an in-memory exporter for span + log objects. Closes #39.

Testing

Added unit tests.

@fractalwrench fractalwrench requested a review from a team as a code owner January 16, 2026 11:28
@codecov
Copy link

codecov bot commented Jan 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.71%. Comparing base (5c702f4) to head (9ced2f4).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #54      +/-   ##
==========================================
+ Coverage   90.65%   90.71%   +0.06%     
==========================================
  Files         210      214       +4     
  Lines        2279     2295      +16     
  Branches      233      233              
==========================================
+ Hits         2066     2082      +16     
  Misses        160      160              
  Partials       53       53              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fractalwrench fractalwrench force-pushed the fw/in-memory-exporters branch 2 times, most recently from 7c99a5a to edad551 Compare January 16, 2026 14:36
Copy link
Member

@Msksgm Msksgm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@bidetofevil bidetofevil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be under a test source set? It doesn't feel like it is robust enough to be used for production given that the telemetry are kept in memory indefinitely, so it feels like it should either be strictly for testing, or need a bit more safety around it to prevent it being a memory-leaking foot-gun

@fractalwrench fractalwrench force-pushed the fw/in-memory-exporters branch from edad551 to f32e0c8 Compare January 22, 2026 11:51
@fractalwrench
Copy link
Member Author

@bidetofevil how about providing them in a separate module named something like exporters-in-memory? That would make it clearer that it's not included by default for a reason.

@bidetofevil
Copy link

Anything that makes it clear they aren't intended for production usage would work for me.

@fractalwrench
Copy link
Member Author

Moved the classes to a separate module.

Copy link

@bidetofevil bidetofevil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@Msksgm Msksgm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fractalwrench fractalwrench merged commit 5f111d7 into open-telemetry:main Jan 26, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create in-memory exporters

3 participants