Skip to content

Conversation

@priettt
Copy link

@priettt priettt commented Jan 25, 2026

Goal

Upgrade Android Gradle Plugin from 8.13.2 to 9.0.0.

Changes

  • Bump AGP version to 9.0.0
  • Bump androidx-benchmark to 1.5.0-alpha01 for AGP 9 compatibility
  • Rename plugins in libs.versions.toml (androidLibraryandroid-kotlin-multiplatform-library, kotlinMultiplatformkotlin-multiplatform)
  • Extract Android target configuration to KotlinAndroidTargetConfig.kt
  • Restructure BuildPlugin to keep common multiplatform config separate from android-specific config
  • Fix BuildPlugin to ensure configurePublishing() runs for all modules (fixes compat-bom publishing)
  • Fix compat-bom to properly import OpenTelemetry Java BOM version constraints
  • Restore kotlin.android plugin in telescope-app example

@priettt priettt requested a review from a team as a code owner January 25, 2026 23:55
@codecov
Copy link

codecov bot commented Jan 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.82%. Comparing base (5a2e684) to head (2ebcca4).
⚠️ Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #81      +/-   ##
==========================================
- Coverage   90.49%   89.82%   -0.68%     
==========================================
  Files         210      215       +5     
  Lines        2272     2338      +66     
  Branches      233      233              
==========================================
+ Hits         2056     2100      +44     
- Misses        163      185      +22     
  Partials       53       53              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@fractalwrench fractalwrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good. One question about withPlugin and also the CI is failing when building the telescope app.

@@ -9,19 +10,24 @@ class BuildPlugin : Plugin<Project> {

override fun apply(project: Project) {
project.pluginManager.withPlugin("org.jetbrains.kotlin.multiplatform") {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks kind of strange. Do both plugins get applied always? Is it necessary to nest the withPlugin calls or would it function the same outside of this lambda?

Copy link
Author

@priettt priettt Jan 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did this so I could access the new KotlinMultiplatformAndroidLibraryTarget, but I think it's an oversight. Some modules might not apply that plugin, and hence they won't be published. That's why CI isn't passing I believe.

I'll rethink this!

@priettt priettt closed this Jan 26, 2026
@priettt priettt reopened this Jan 26, 2026
@priettt
Copy link
Author

priettt commented Jan 26, 2026

closing PR due to a mistake in the upstream repo

@priettt priettt closed this Jan 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants