-
Notifications
You must be signed in to change notification settings - Fork 7
Upgrade to AGP 9 #81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to AGP 9 #81
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #81 +/- ##
==========================================
- Coverage 90.49% 89.82% -0.68%
==========================================
Files 210 215 +5
Lines 2272 2338 +66
Branches 233 233
==========================================
+ Hits 2056 2100 +44
- Misses 163 185 +22
Partials 53 53 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fractalwrench
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks mostly good. One question about withPlugin and also the CI is failing when building the telescope app.
| @@ -9,19 +10,24 @@ class BuildPlugin : Plugin<Project> { | |||
|
|
|||
| override fun apply(project: Project) { | |||
| project.pluginManager.withPlugin("org.jetbrains.kotlin.multiplatform") { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks kind of strange. Do both plugins get applied always? Is it necessary to nest the withPlugin calls or would it function the same outside of this lambda?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did this so I could access the new KotlinMultiplatformAndroidLibraryTarget, but I think it's an oversight. Some modules might not apply that plugin, and hence they won't be published. That's why CI isn't passing I believe.
I'll rethink this!
|
closing PR due to a mistake in the upstream repo |
Goal
Upgrade Android Gradle Plugin from 8.13.2 to 9.0.0.
Changes
androidLibrary→android-kotlin-multiplatform-library,kotlinMultiplatform→kotlin-multiplatform)configurePublishing()runs for all modules (fixes compat-bom publishing)