Skip to content

Commit cc98f69

Browse files
committed
Fix review comments
Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
1 parent 24e884e commit cc98f69

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

docs/rfcs/instrumentation-v1beta1.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ Not all language SDKs support declarative configuration yet. See [language-suppo
4646
- **Python** — supported ([#4856](https://github.com/open-telemetry/opentelemetry-python/issues/4856))
4747
- **Node.js** — in progress
4848
- **Go** — in progress
49-
- **.NET**not supported ([#6380](https://github.com/open-telemetry/opentelemetry-dotnet/issues/6380))
49+
- **.NET**in progress ([#6380](https://github.com/open-telemetry/opentelemetry-dotnet/issues/6380), [#7413](https://github.com/open-telemetry/opentelemetry-dotnet/pull/7413))
5050

5151
The operator will **skip injection** for languages that do not support declarative configuration when `spec.declarativeConfig` is set. For example, using `declarativeConfig` with `.NET` auto-instrumentation will result in the pod mutation webhook skipping injection and emitting a warning event.
5252

@@ -212,7 +212,7 @@ spec:
212212
includeUIDs: true
213213
# Service identity attributes (service.name, service.version, service.namespace, service.instance.id)
214214
# Derived from K8s metadata following OTel semantic conventions precedence.
215-
# See: https://opentelemetry.io/docs/specs/semconv/non-normative/k8s-attributes/
215+
# See: https://opentelemetry.io/docs/specs/semconv/non-normative/k8s-attributes/#service-attributes
216216
serviceMetadata:
217217
# Set to false to disable automatic service attribute derivation. Defaults to true.
218218
enabled: true

0 commit comments

Comments
 (0)