Enable context-flattening to support context field searching#491
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #491 +/- ##
============================================
- Coverage 82.56% 81.35% -1.22%
+ Complexity 2306 1587 -719
============================================
Files 156 95 -61
Lines 8571 5759 -2812
============================================
- Hits 7077 4685 -2392
+ Misses 1494 1074 -420 Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
nickmarden
force-pushed
the
feat/first-class-context-fields
branch
from
c13169b to
2e340d8
Compare
|
@brettmc I'm unclear how to trigger another CI run. I believe I've fixed all but one of the previously-failing CI tests, but I can't be sure. Is this something you need to trigger, or can I? |
arthurmartelli
force-pushed
the
feat/first-class-context-fields
branch
from
2e340d8 to
ff353e9
Compare
|
Hi @brettmc, I just updated the fork by re-basing to main. Could you please run CI? thanks! |
| ->setSeverityNumber(Severity::fromPsr3($log->level)); | ||
|
|
||
| if ($this->flattenAttributes) { | ||
| foreach ($this->buildFlattenedAttributes($contextToProcess) as $key => $value) { |
There was a problem hiding this comment.
Could https://laravel.com/docs/13.x/helpers#method-array-dot work here instead? 🤔
There was a problem hiding this comment.
The implementation is much cleaner with that array method :)
arthurmartelli
force-pushed
the
feat/first-class-context-fields
branch
from
1c55e20 to
42197ac
Compare
Replace the custom recursive flattenArray() method and the manual normalization loop with a single array_map() + Arr::dot() expression, removing ~25 lines of bespoke logic.
arthurmartelli
force-pushed
the
feat/first-class-context-fields
branch
from
42197ac to
60ee14a
Compare
ChrisLightfootWild
merged commit 7392a9b
into
open-telemetry:main
4 participants
Description
Resolves open-telemetry/opentelemetry-php#1837
This PR adds an optional configuration to flatten log context attributes into individual OTLP attributes, improving searchability in observability backends.
Problem
The Laravel LogWatcher currently JSON-encodes the entire log context into a single context attribute:
context: {"http":{"method":"GET","path":"/users","status":200},"user_id":"123"}
This makes it impossible to search/filter by specific values (e.g., http.method = "GET") in backends like SigNoz, Jaeger, or Grafana.
Solution
A new configuration option OTEL_PHP_LARAVEL_LOG_ATTRIBUTES_FLATTEN that, when enabled, spreads context as individual attributes with dot-notation for nested arrays:
http.method: GET
http.path: /users
http.status: 200
user_id: 123
Changes
Backward Compatibility
Testing
./vendor/bin/phpunit --testsuite=unit # 18 tests, 42 assertions
./vendor/bin/phpunit --testsuite=integration # 21 tests, 120 assertions
Screenshot