Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion script/semantic-conventions/semconv.sh
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ SPEC_DIR="${ROOT_DIR}/var/semantic-conventions"
CODE_DIR="${ROOT_DIR}/src/SemConv"

# freeze the spec & generator tools versions to make SemanticAttributes generation reproducible
SEMCONV_VERSION=1.36.0
SEMCONV_VERSION=1.37.0
SPEC_VERSION=v$SEMCONV_VERSION
SCHEMA_URL=https://opentelemetry.io/schemas/$SEMCONV_VERSION
OTEL_WEAVER_IMG_VERSION=v0.17.1
Expand Down
5 changes: 3 additions & 2 deletions src/SemConv/Attributes/HttpAttributes.php
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,9 @@ interface HttpAttributes
/**
* HTTP request method.
* HTTP request method value SHOULD be "known" to the instrumentation.
* By default, this convention defines "known" methods as the ones listed in [RFC9110](https://www.rfc-editor.org/rfc/rfc9110.html#name-methods)
* and the PATCH method defined in [RFC5789](https://www.rfc-editor.org/rfc/rfc5789.html).
* By default, this convention defines "known" methods as the ones listed in [RFC9110](https://www.rfc-editor.org/rfc/rfc9110.html#name-methods),
* the PATCH method defined in [RFC5789](https://www.rfc-editor.org/rfc/rfc5789.html)
* and the QUERY method defined in [httpbis-safe-method-w-body](https://datatracker.ietf.org/doc/draft-ietf-httpbis-safe-method-w-body/?include_text=1).
*
* If the HTTP request method is not known to instrumentation, it MUST set the `http.request.method` attribute to `_OTHER`.
*
Expand Down
11 changes: 9 additions & 2 deletions src/SemConv/Incubating/Attributes/HttpIncubatingAttributes.php
Original file line number Diff line number Diff line change
Expand Up @@ -66,8 +66,9 @@ interface HttpIncubatingAttributes
/**
* HTTP request method.
* HTTP request method value SHOULD be "known" to the instrumentation.
* By default, this convention defines "known" methods as the ones listed in [RFC9110](https://www.rfc-editor.org/rfc/rfc9110.html#name-methods)
* and the PATCH method defined in [RFC5789](https://www.rfc-editor.org/rfc/rfc5789.html).
* By default, this convention defines "known" methods as the ones listed in [RFC9110](https://www.rfc-editor.org/rfc/rfc9110.html#name-methods),
* the PATCH method defined in [RFC5789](https://www.rfc-editor.org/rfc/rfc5789.html)
* and the QUERY method defined in [httpbis-safe-method-w-body](https://datatracker.ietf.org/doc/draft-ietf-httpbis-safe-method-w-body/?include_text=1).
*
* If the HTTP request method is not known to instrumentation, it MUST set the `http.request.method` attribute to `_OTHER`.
*
Expand Down Expand Up @@ -138,6 +139,12 @@ interface HttpIncubatingAttributes
*/
public const HTTP_REQUEST_METHOD_VALUE_TRACE = 'TRACE';

/**
* QUERY method.
* @stable
*/
public const HTTP_REQUEST_METHOD_VALUE_QUERY = 'QUERY';

/**
* Any HTTP method that the instrumentation has no prior knowledge of.
* @stable
Expand Down
Loading