Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve confluent-kafka instrumentation examples #3369

Merged
merged 4 commits into from
Mar 21, 2025
+10 −5
Merged

Improve confluent-kafka instrumentation examples #3369

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ab3b090
Improve confluent-kafka instrumentation example
andremm Mar 14, 2025
c6e810c
Improve confluent-kafka tracer provider example
andremm Mar 17, 2025
6e1c6cc
Apply suggestions from code review
xrmx Mar 17, 2025
bb686cc
Merge branch 'main' into confluent-kafka-snippet
xrmx Mar 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions ...rumentation-confluent-kafka/src/opentelemetry/instrumentation/confluent_kafka/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,9 @@
# report a span of type consumer with the default settings
consumer = Consumer(conf2)

def msg_process(msg):
print(msg)

def basic_consume_loop(consumer, topics):
try:
consumer.subscribe(topics)
Expand All @@ -44,7 +47,7 @@ def basic_consume_loop(consumer, topics):
if msg.error():
if msg.error().code() == KafkaError._PARTITION_EOF:
# End of partition event
sys.stderr.write(f"{msg.topic() [{msg.partition()}] reached end at offset {msg.offset()}}")
sys.stderr.write(f"{msg.topic()} [{msg.partition()}] reached end at offset {msg.offset()}")
elif msg.error():
raise KafkaException(msg.error())
else:
Expand All @@ -53,7 +56,7 @@ def basic_consume_loop(consumer, topics):
# Close down consumer to commit final offsets.
consumer.close()

basic_consume_loop(consumer, "my-topic")
basic_consume_loop(consumer, ["my-topic"])

The _instrument method accepts the following keyword args:
tracer_provider (TracerProvider) - an optional tracer provider
Expand All @@ -72,14 +75,16 @@ def instrument_consumer(consumer: Consumer, tracer_provider=None)
.. code:: python

from opentelemetry.instrumentation.confluent_kafka import ConfluentKafkaInstrumentor
from opentelemetry.trace import get_tracer_provider

from confluent_kafka import Producer, Consumer

inst = ConfluentKafkaInstrumentor()
tracer_provider = get_tracer_provider()

p = confluent_kafka.Producer({'bootstrap.servers': 'localhost:29092'})
c = confluent_kafka.Consumer({
'bootstrap.servers': 'localhost:29092',
p = Producer({'bootstrap.servers': 'localhost:9092'})
c = Consumer({
'bootstrap.servers': 'localhost:9092',
'group.id': 'mygroup',
'auto.offset.reset': 'earliest'
})
Expand Down