feat: wrappers for async responses methods.#4325
Open
eternalcuriouslearner wants to merge 6 commits intoopen-telemetry:mainfrom
Open
feat: wrappers for async responses methods.#4325eternalcuriouslearner wants to merge 6 commits intoopen-telemetry:mainfrom
eternalcuriouslearner wants to merge 6 commits intoopen-telemetry:mainfrom
Conversation
wrisa
approved these changes
Mar 11, 2026
lmolkova
reviewed
Mar 12, 2026
| @property | ||
| def response(self): | ||
| response = self.stream.response | ||
| response = self.stream._response |
Member
There was a problem hiding this comment.
is this reliable given it's internal? Can we check that the property exists and gracefully skip instrumentation for streams otherwise?
There was a problem hiding this comment.
Yeah this is reliable but added a defensive guard to fallback to response if _response is unavailable.
| return suppressed | ||
|
|
||
| def parse(self) -> "AsyncResponseStreamManagerWrapper[TextFormatT]": | ||
| raise NotImplementedError( |
Member
There was a problem hiding this comment.
OTel instrumentations should not throw - we can't break user apps, we can probably just ignore this call?
There was a problem hiding this comment.
This is temporarily added based on previous pr feedback. I am going to remove this once I wire in instrumentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add async OpenAI Responses API stream wrappers for
AsyncResponseStreamandAsyncResponseStreamManagerin the OpenAI v2 instrumentation, mirroring the existing sync wrapper behavior for telemetry finalization, failure handling, and wrapped response cleanup. This also extends the response wrapper unit coverage to include async manager entry/exit behavior and async stream__aexit__,close(),until_done(),response.aclose(), andget_final_response()flows.This closes the parity gap between the sync and async Responses streaming wrapper implementations so the async SDK path can be instrumented with the same cleanup and error-handling guarantees. No new runtime dependencies were added; the change uses the existing OpenAI instrumentation package and test dependencies.
Fixes #3436 partly
Type of change
How Has This Been Tested?
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.