Fix "unknown keyword: :label" ArgumentError in Rdkafka #1321
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
venkatagiri
requested review from
fbogsany,
mwear,
robertlaurin,
dazuma,
ericmustin,
arielvalentin,
ahayworth,
plantfansam,
robbkidd,
simi,
kaylareopelle,
xuan-cao-swi and
a team
as code owners
The committers listed above are authorized under a signed CLA. |
arielvalentin
requested changes
Jan 6, 2025
There was a problem hiding this comment.
Thank you for your contribution!
I would like to request a few changes here:
- Please add an automated test to avoid regressions
- This change should ensure that the instrumentation requires a minimal version compatible for rdkafka v0.15.0 e.g. https://github.com/open-telemetry/opentelemetry-ruby-contrib/blob/main/instrumentation/rdkafka/lib/opentelemetry/instrumentation/rdkafka/instrumentation.rb#L12
- We may want to consider releasing a version of the instrumentation that checks for a Max compatibility with v0.14.x and release that first then release this PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for adding a label to a kafka payload(within rdkafka) was added in v0.15.0. karafka/rdkafka-ruby#381
This PR updates the method signature to allow
labelkeyword argument.