feat: Redis metrics #1377
Draft
feat: Redis metrics #1377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
zvkemp
commented
Jan 29, 2025
•
zvkemp
commented
- requires feat: gradually add metrics capabilities to Instrumentation::Base #1324
- requires feat: advisory parameters for metrics instruments opentelemetry-ruby#1801
- There's quite a bit of duplication here between the (now 4) different mixins; see if that can be reduced
- needs rebase now that the redis 5 branch has been merged
zvkemp
commented
Jan 29, 2025
Additionally: - Add a redis 5 appraisal - use RedisClient in RedisClient tests
zvkemp
force-pushed
the
redis-metrics
branch
2 times, most recently
from
c3127c8 to
f2b97e7
Compare
4 tasks
|
👋 This pull request has been marked as stale because it has been open with no activity. You can: comment on the issue or remove the stale label to hold stale off for a while, add the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.