feat!: use trace_based exemplar filter by default#2112
Open
bdewater-thatch wants to merge 1 commit intoopen-telemetry:mainfrom
Open
feat!: use trace_based exemplar filter by default#2112bdewater-thatch wants to merge 1 commit intoopen-telemetry:mainfrom
bdewater-thatch wants to merge 1 commit intoopen-telemetry:mainfrom
Conversation
bdewater-thatch
requested review from
ahayworth,
arielvalentin,
dazuma,
ericmustin,
fbogsany,
kaylareopelle,
mwear,
plantfansam,
robbkidd,
robertlaurin and
xuan-cao-swi
as code owners
xuan-cao-swi
approved these changes
Apr 30, 2026
Contributor
xuan-cao-swi
left a comment
xuan-cao-swi
left a comment
There was a problem hiding this comment.
The intent was to ensure that metrics users do not experience any unanticipated overhead.
This is a breaking change so probably should use feat!
bdewater-thatch
changed the title
bdewater-thatch
force-pushed
the
fix-metrics-exemplar-default
branch
from
6a03bad to
7689208
Compare
Contributor
Author
|
@xuan-cao-swi thanks for the feedback - fixed! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My coworkers complained about the
OTEL_METRICS_EXEMPLAR_FILTER is not part of the provided exemplar filters. Exemplar is offwarning that started popping up after we added the metrics SDK to our app. The ENV read also triggered before one can setOpenTelemetry.meter_provider.enable_exemplar_filterso that was a little bit annoying.According to https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/configuration/sdk-environment-variables.md#exemplar trace_based is the default so that's what I implemented and it makes the aforementioned warning go away when the ENV var isn't explicitly set.