Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add pr naming workflow #2698

Merged

Conversation

scottgerring
Copy link
Contributor

@scottgerring scottgerring commented Feb 21, 2025

Changes

Adds a workflow to ensure that PR names conform to the conventional commits standard. This will make our commit history going forward consistent, and will (hopefully!) make it easier to generate changelogs at a later stage.

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@scottgerring scottgerring changed the title chore: add pr naming workflow blurp: add pr naming workflow Feb 21, 2025
Copy link

codecov bot commented Feb 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.3%. Comparing base (64549d7) to head (45a5b9b).
Report is 2 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #2698   +/-   ##
=====================================
  Coverage   79.3%   79.3%           
=====================================
  Files        123     123           
  Lines      22660   22660           
=====================================
  Hits       17977   17977           
  Misses      4683    4683           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@scottgerring scottgerring changed the title blurp: add pr naming workflow chore(CI/CD): add pr naming workflow Feb 21, 2025
@scottgerring scottgerring force-pushed the chore/semantic-commits branch from 7adcb0c to ed19c75 Compare February 21, 2025 10:21
@scottgerring scottgerring marked this pull request as ready for review February 24, 2025 07:07
@scottgerring scottgerring requested a review from a team as a code owner February 24, 2025 07:07
@scottgerring scottgerring changed the title chore(CI/CD): add pr naming workflow ci: add pr naming workflow Feb 24, 2025
Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with couple of comments.

@cijothomas cijothomas changed the title ci: add pr naming workflow foo: add pr naming workflow Feb 24, 2025
@cijothomas cijothomas closed this Feb 24, 2025
@cijothomas cijothomas reopened this Feb 24, 2025
@cijothomas cijothomas changed the title foo: add pr naming workflow ci: add pr naming workflow Feb 24, 2025
@cijothomas cijothomas closed this Feb 24, 2025
@cijothomas cijothomas reopened this Feb 24, 2025
@scottgerring
Copy link
Contributor Author

@lalitb @cijothomas addressed comments; should be good to merge.

@cijothomas cijothomas merged commit bfd9f31 into open-telemetry:main Feb 25, 2025
22 checks passed
@scottgerring scottgerring deleted the chore/semantic-commits branch March 14, 2025 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants