-
Notifications
You must be signed in to change notification settings - Fork 507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Error cleanups continued #2838
fix: Error cleanups continued #2838
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2838 +/- ##
=====================================
Coverage 80.8% 80.9%
=====================================
Files 124 124
Lines 23743 23726 -17
=====================================
Hits 19200 19200
+ Misses 4543 4526 -17 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall I think this is a good idea - there's not much value in propagating 1 million error variants back to a caller that ignores them - but I wonder if we shouldn't try and use Error
trait impls in everything that returns errors for consistency and clarity?
done. |
Continuing from #2790 this actually closes #2561
Also additional cleanup done in InMemoryExporter to not use the to-be-removed-in-next-pr Error types.